jadams-tresys commented on a change in pull request #55: Fixes the issue of separated empty optional elements, (ie. 1:2::4:5). URL: https://github.com/apache/incubator-daffodil/pull/55#discussion_r175484186
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ElementKindUnparsers.scala ########## @@ -54,25 +54,22 @@ class SequenceCombinatorUnparser(ctxt: ModelGroupRuntimeData, childUnparsers: Ve override def nom = "Sequence" - // Sequences of nothing (no initiator, no terminator, nothing at all) should - // have been optimized away - Assert.invariant(childUnparsers.length > 0) Review comment: Added back in, doesn't cause any issues. I think this was something that Mike and I threw in when we were initially debugging this issue and forgot to remove. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
