stevedlawrence commented on a change in pull request #61: Preliminary Review -
Base64 layering runs first parsing unit test.
URL: https://github.com/apache/incubator-daffodil/pull/61#discussion_r181423750
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
##########
@@ -245,6 +248,31 @@ abstract class SequenceTermBase(
maybeCheckBitOrderAndCharset)
}
+ private val layeredSequenceAllowedProps = Set("ref", "layerTransform",
"layerEncoding", "layerLengthKind", "layerLength", "layerLengthUnits",
"layerTerminator")
+
+ final lazy val maybeLayerTransformerEv: Maybe[LayerTransformerEv] = {
+ if (maybeLayerTransformEv.isEmpty) Maybe.Nope
Review comment:
Should this SDE if any other layering properties are defined? Sort of the
reverse to the below check? Any really, should that even be an SDE. There are
plenty of cases right now where we ignore properties because they do not apply
(e.g. dfdl:lengthKind="delimieted", but dfdl:length is provided). It seems like
this is related to the DAFFODIL-441 and some other related bugs about warning
on ignore properties. This seems to fall into that category of bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
