efinnegan commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r190993423
##########
File path:
daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaext2.tdml
##########
@@ -327,7 +327,7 @@
<document><documentPart
type="byte">000000000000003C</documentPart></document>
<infoset>
<dfdlInfoset
xmlns:xs="http://www.w3.org/2001/XMLSchema";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
- <testBinaryMilliseconds
xsi:type="xs:dateTime">2009-12-24T05:15:00.060000+05:00</testBinaryMilliseconds>
+ <testBinaryMilliseconds
xsi:type="xs:dateTime">2009-12-24T05:15:00.060000+00:00</testBinaryMilliseconds>
Review comment:
I removed the time zones from the binaryCalendarEpoch because I think Steve
noted before that it shouldn't be using the calendarPattern because that
doesn't apply for binarySeconds and binaryMilliseconds. So when parsing the
epochCalendar I am using the default pattern for dateTime which is
"yyyy-MM-dd'T'HH:mm:ss".
But if calendarTimeZone doesn't apply here either than this is wrong too
since I was using it for epochCalendar. So without specifying a pattern for
epochCalendar can we allow both "yyyy-MM-dd'T'HH:mm:ss" and
"yyyy-MM-dd'T'HH:mm:ssZZZZ"? Then the first would use UTC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
