stevedlawrence commented on a change in pull request #70: Adding property binaryCalendarRep with values "binarySeconds" and "bi… URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r192198408
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ConvertBinaryCalendarUnparser.scala ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.processors.unparsers + +import org.apache.daffodil.calendar.DFDLCalendar +import org.apache.daffodil.exceptions.Assert +import org.apache.daffodil.io.DataOutputStream +import org.apache.daffodil.io.FormatInfo +import org.apache.daffodil.processors.ElementRuntimeData +import org.apache.daffodil.schema.annotation.props.gen.BinaryCalendarRep +import org.apache.daffodil.util.Maybe.One +import org.apache.daffodil.util.Misc + +import com.ibm.icu.util.Calendar + +case class ConvertBinaryCalendarUnparser( + override val context: ElementRuntimeData, + binCalRep: BinaryCalendarRep, + epochTimeMillis: Long, + lengthInBits: Int, + hasTZ: Boolean) + extends PrimUnparser { + + /** + * Primitive unparsers must override runtimeDependencies + */ + override lazy val runtimeDependencies = Nil + + protected def putNumber(dos: DataOutputStream, value: Long, nBits: Int, finfo: FormatInfo): Boolean = { + dos.putLong(value, nBits, finfo) + } + + def unparse(state: UState): Unit = { + + val node = state.currentInfosetNode.asSimple + + val calValue = node.dataValue match { + case dc: DFDLCalendar => dc.calendar + case x => Assert.invariantFailed("ConvertTextCalendar received unsupported type. %s of type %s.".format(x, Misc.getNameFromClass(x))) + } + + // Adjust the time based on time zone. + val epochTime = if (!hasTZ) { + val tz = calValue.getTimeZone + var gmtOffset = calValue.get(Calendar.ZONE_OFFSET) + if (tz.inDaylightTime(calValue.getTime)) gmtOffset += tz.getDSTSavings + epochTimeMillis - gmtOffset Review comment: Can you add a comment about what's going on here? It's not immediately obvious to me why things like DST is needed. You might also make it more scala-y by not using a var. Maybe something like: ``` val gmtOffset = ... val dstOffset = if (tz.inDaylightTime(...)) tz.getDSTSavings else 0 epochTimeMillis - (gmtOffset + dstOffset) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
