mbeckerle commented on a change in pull request #77: Modifications to IO layer
to support streaming input data
URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201042080
##########
File path:
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharset.scala
##########
@@ -54,6 +51,7 @@ trait BitsCharset extends Serializable {
case _ => false
}
def name: String
+ def aliases: Seq[String] = Nil
Review comment:
See above at Line 40 - the comment needs to be updated. The motivation for
BitsCharset is not the same anymore as it was. It's not about final methods,
but the excessive complexity of dealing with Java charset and decoders/encoders.
I can't comment on a line that's not part of the diff, so put this comment
here at the first Diff line after.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
