stevedlawrence commented on a change in pull request #77: Modifications to IO
layer to support streaming input data
URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201099700
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala
##########
@@ -255,7 +255,7 @@ class Compiler(var validateDFDLSchemas: Boolean = true)
def reload(savedParser: File) = reload(new
FileInputStream(savedParser).getChannel())
- def reload(savedParser: DFDL.Input): DFDL.DataProcessor = {
+ def reload(savedParser: java.nio.channels.ReadableByteChannel):
DFDL.DataProcessor = {
Review comment:
The save/reload method weren't change, only the parse method, and that was
necessary to support multiple calls to parse() using the same input. There
isn't really the same motivaction here since it's just saving/reloading
parsers. But it might be nice for consistency? I'll create a bug think about
changing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
