stevedlawrence commented on a change in pull request #88: Daffodil 1919
separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r208311521
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/LayeredSequenceUnparser.scala
##########
@@ -17,13 +17,14 @@
package org.apache.daffodil.processors.unparsers
-import org.apache.daffodil.processors.{ LayerTransformerEv,
ModelGroupRuntimeData }
+import org.apache.daffodil.processors.LayerTransformerEv
import org.apache.daffodil.io.DirectOrBufferedDataOutputStream
+import org.apache.daffodil.processors.SequenceRuntimeData
-class LayeredSequenceUnparser(ctxt: ModelGroupRuntimeData,
+class LayeredSequenceUnparser(ctxt: SequenceRuntimeData,
layerTransformerEv: LayerTransformerEv,
- childUnparser: Unparser)
- extends SequenceCombinatorUnparser(ctxt, Vector(childUnparser)) {
Review comment:
It looks like the child parsers in the SequenceParserBase are accessed via
an array index, which I believe is O(n) for Seqs (i.e. Lists)? Should we stick
with the Vector or something else with constant index lookup and ensure other
places where we pass Seq's of parsers into the SequenceParsers use Vector's as
well, so those lookups are O(1)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
