stevedlawrence commented on a change in pull request #92: Update dependencies
to their latest versions
URL: https://github.com/apache/incubator-daffodil/pull/92#discussion_r209621364
##########
File path: project/Dependencies.scala
##########
@@ -22,30 +22,30 @@ object Dependencies {
lazy val common = core ++ infoset ++ test
lazy val core = Seq(
- "org.scala-lang.modules" %% "scala-xml" % "1.0.6",
- "org.scala-lang.modules" %% "scala-parser-combinators" % "1.0.4",
- "com.ibm.icu" % "icu4j" % "51.1", // new versions avail. 58.1 requires
code changes
- "xerces" % "xercesImpl" % "2.10.0",
+ "org.scala-lang.modules" %% "scala-xml" % "1.1.0",
+ "org.scala-lang.modules" %% "scala-parser-combinators" % "1.1.1",
+ "com.ibm.icu" % "icu4j" % "62.1",
Review comment:
I'm not sure that's totally necessary. If an ICU update fixes the bugs, new
tests I've added should fail. And I've referenced JIRA bugs associated with the
specific tests. So if we update and things start failing, it should be pretty
clear which bugs are specific to which tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
