mbeckerle commented on a change in pull request #129: Cross Testing Capability
with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r230862612
##########
File path:
daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -209,8 +216,9 @@ class DFDLTestSuite private[tdml] (
// System.err.println("TDMLRunner Error: " + exception.getMessage())
isLoadingError = true
}
+
def fatalError(exception: SAXParseException) = {
- loadingExceptions == exception +: loadingExceptions
+ loadingExceptions = exception :: loadingExceptions
// System.err.println("TDMLRunner Fatal Error: " +
exception.getMessage())
Review comment:
The +: vs :: is a no-op. both are equivalent here. It's the fact that it was
"==" and nothing was telling us we were always going to be false, or that we
were a pure boolean expression that would be ignored that was egregious.
I don't undestand this one either really. Just spotted it by inspection. I
found several situations where code warnings weren't being issued. E.g., things
like
x match {
case y => expr 1
expr 2
case z ....
That is, where the braces were missing around expr1 and expr2 to group them
as part of case y.
Not sure why we weren't getting warned on this. Scala 2.12 compiler may need
more options to turn on this level of checking maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
