mbeckerle commented on a change in pull request #150: Removed use of
ThreadLocal for DFA Register Pool.
URL: https://github.com/apache/incubator-daffodil/pull/150#discussion_r241061352
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
##########
@@ -119,8 +122,7 @@ trait SetProcessorMixin {
* which should be isolated to the alternative parser, and repParsers, i.e.,
* places where points-of-uncertainty are handled.
*/
-abstract class ParseOrUnparseState protected (
- protected var variableBox: VariableBox,
+abstract class ParseOrUnparseState protected (protected var variableBox:
VariableBox,
var diagnostics: List[Diagnostic],
Review comment:
You asked what style we "should" use. I think we should use the default
standard indentation format for scala. One would hope all tools would default
to this, but I'm not sure they agree on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
