stevedlawrence commented on a change in pull request #152: Daffodil 2028 cross
test
URL: https://github.com/apache/incubator-daffodil/pull/152#discussion_r241105683
##########
File path:
daffodil-lib/src/main/resources/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd
##########
@@ -93,6 +101,17 @@
utf16Width="fixed"
/>
</dfdl:defineFormat>
+
+ <dfdl:defineFormat name="GeneralFormat">
+ <dfdl:format ref="GeneralFormatOriginal" />
+ </dfdl:defineFormat>
+
+ <dfdl:defineFormat name="GeneralFormatForCrossTesting">
+ <dfdl:format ref="GeneralFormatOriginal"
+ calendarTimeZone="UTC"
+ encodingErrorPolicy="error"
+ />
+ </dfdl:defineFormat>
Review comment:
Wondering if this new format should go in src/test/resources somewhere if it
really is just for testing purposes? My concen is that anything in this file is
probably something we should officially support and might want to worry about
backward compatability issues. If it's in src/test/resources, we can changeit
whenever we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
