stevedlawrence commented on a change in pull request #168: Keep line/column
info for Daffodil tests
URL: https://github.com/apache/incubator-daffodil/pull/168#discussion_r249777949
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilConstructingLoader.scala
##########
@@ -72,7 +72,7 @@ object Position {
* gets positions is different. It is given just an offset into the document
file/stream,
* and it therefore must synthesize line number/col number info itself.
*/
-class DaffodilConstructingLoader(uri: URI, errorHandler:
org.xml.sax.ErrorHandler, addLineColInfo: Boolean = false)
+class DaffodilConstructingLoader(uri: URI, errorHandler:
org.xml.sax.ErrorHandler, addLineColInfo: Boolean = true)
Review comment:
Is it worth removeing the addLineColInfo paramter? We never use it anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
