stevedlawrence opened a new pull request #169: Fix incorrect line numbers and ensure XML errors include line numbers URL: https://github.com/apache/incubator-daffodil/pull/169 - A bug in scala-xml caused line numbers to be reset to zero after parsing CDATA and processing instructions. This can be worked around by calling lookahead() when a DaffodilConstructingLoader is initialized - When using the DaffodilConstructingLoader to parse XML, if any exceptions are thrown, convert them to SAXParseExceptions and return null. This makes our errors consistent and also causes line numbers to be included in errors that previously did not (e.g. missing closing tag) - Change the DaffodilConstructingLoader to override the elem(...) function to add file/line/column attributes there instead of overriding xTag and mkAttributes. Those functions are probably less safe to override since they are more internal to the scala-xml ConstructingLoader, and they also required position state to be carried around outside. Using the elem function is a bit cleaner and probably safer - Remove the addColLineInfo flag. We need to handle removing line/col information for IBM compatibility differently as part of another commit. It's too difficult to use this flag in the way that's intended. DAFFODIL-1476
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
