stevedlawrence commented on a change in pull request #178: Created Windows MSI 
installer package.
URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254722041
 
 

 ##########
 File path: daffodil-cli/src/windows/Product.wxs
 ##########
 @@ -0,0 +1,376 @@
+<?xml version="1.0" encoding="UTF-8"?>
 
 Review comment:
   Github isn't showing the LICENSE.rtf, so I'll put the comment here.
   
   I'd really like to avoid maintenence of a second License.rtf file that has 
very subtle differences from the main license file. How legible is an auto 
generated RTF file in the installer? Perhaps we could so soemthing like chang 
the license agreement page to use smaller font so things are less likely to 
wrap?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to