ltapilot commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254786250
########## File path: daffodil-cli/build.sbt ########## @@ -26,10 +31,9 @@ enablePlugins(RpmPlugin) executableScriptName := "daffodil" packageName in Universal := "apache-daffodil-" + version.value + "-incubating-bin" //tarball name - packageName in Linux := executableScriptName.value - packageName in Rpm := "apache-" + executableScriptName.value +packageName in Windows := executableScriptName.value Review comment: I played with this a bit and found that 'packageName in Windows' changes and controls *nothing*. I made the recommended change and it had *no* effect on the behavior of the resulting MSI file. Since it is more consistent with the other stuff I'm leaving that change in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
