stevedlawrence commented on a change in pull request #179: Return xs:decimal
when dividing xs:long
URL: https://github.com/apache/incubator-daffodil/pull/179#discussion_r254827502
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dpath/NodeInfoUtils.scala
##########
@@ -86,7 +86,7 @@ object NodeInfoUtils {
case Decimal => Decimal
case Integer => Decimal
case Double => Double
- case Long => Double
+ case Long => Decimal
case Float => Float
case Int => Float
case ArrayIndex => ArrayIndex
Review comment:
The parameter passed into the divResult method comes from the second value
of tuple in the match case below this. That tuple value is always one of
Decimal, Double, Float, Integer, ArrayIndex, Long, or Int. So I think this
match/case is exhastive. Whehter or not that's correct, I'm not 100% sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
