ltapilot commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254846082
########## File path: daffodil-cli/src/windows/DisclaimerDlg_DFDL.wxs ########## @@ -0,0 +1,32 @@ +<?xml version="1.0" encoding="UTF-8"?> +<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> + <Fragment> + <UI> + <Dialog Id="DisclaimerDlg" Width="370" Height="270" Title="!(loc.DisclaimerDlg_Title)"> + <Control Id="Back" Type="PushButton" X="180" Y="243" Width="56" Height="17" Text="!(loc.WixUIBack)" /> + <Control Id="Next" Type="PushButton" X="236" Y="243" Width="56" Height="17" Default="yes" Text="!(loc.WixUINext)"> + <Condition Action="enable">DisclaimerAccepted = "1"</Condition> + </Control> + <Control Id="Cancel" Type="PushButton" X="304" Y="243" Width="56" Height="17" Cancel="yes" Text="!(loc.WixUICancel)"> + <Publish Event="SpawnDialog" Value="CancelDlg">1</Publish> + </Control> + <Control Id="BannerBitmap" Type="Bitmap" X="0" Y="0" Width="370" Height="44" TabSkip="no" Text="!(loc.LicenseAgreementDlgBannerBitmap)" /> + <Control Id="DisclaimerText" Type="ScrollableText" X="20" Y="60" Width="330" Height="160" Sunken="yes" TabSkip="no"> + <!-- This is the original line --> + <!--<Text SourceFile="!(wix.WixUIDisclaimerRtf=$(var.DisclaimerRtf))" />--> + <!-- To enable Disclaimer localization we change it to this: --> + <Text SourceFile="C:\Users\motto\Documents\Daffodil\incubator-daffodil\daffodil-cli\src\windows\!(loc.DisclaimerRtf)" /> Review comment: Commented XML removed. Changed disclaimer text to come from localization file. Set font size to 'bigger'. changed from scrollable text gadget to static textbox. Deleted DISCLAIMER.rtf file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
