stevedlawrence commented on a change in pull request #194: Fix poor diagnostic.
URL: https://github.com/apache/incubator-daffodil/pull/194#discussion_r264187029
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/cookers/EntityReplacer.scala
##########
@@ -47,8 +47,7 @@ final class EntityReplacer {
val dfdlCharClassEntityName = "NL|WSP|WSP\\*|WSP\\+|ES"
val entityCharacterUnicode: List[(String, String, Matcher)] =
- List(
- ("NUL", "\u0000", Pattern.compile("%" + "NUL" + ";",
Pattern.MULTILINE).matcher("")),
+ List(("NUL", "\u0000", Pattern.compile("%" + "NUL" + ";",
Pattern.MULTILINE).matcher("")),
Review comment:
That's too bad. The other syntax is definitely the right thing to do here.
You should probably look into using ``git add -p`` when adding changes to a
commit. It's fine if Eclipse wants to make random changes, but that doesn't
mean all those changes should be comitted, like this case. Using the ``-p``
flag will let you control exactly which hunks are added to a commit and you can
ignore these wrong changes. Or you chould use ``git checkout -p`` to undo
specific changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
