stevedlawrence commented on a change in pull request #208: Output empty
elements with self closing tags
URL: https://github.com/apache/incubator-daffodil/pull/208#discussion_r275985954
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/XMLTextInfosetOutputter.scala
##########
@@ -41,7 +41,7 @@ class XMLTextInfosetOutputter(writer: java.io.Writer,
pretty: Boolean = true)
if (prefix == null || prefix == "") elem.erd.name else prefix + ":" +
elem.erd.name
}
- private def outputStartTag(elem: DIElement, name: String): Unit = {
+ private def outputStartTag(elem: DIElement, name: String, empty:
Boolean=false): Unit = {
Review comment:
Maybe hange this variable to isEmpty to make it more clear it's a boolean? I
think that's the standard we've been using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
