stevedlawrence commented on a change in pull request #210: Add midBitsToEnd layer transform URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r278108630
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/layers/midBitsToEndTransformer.scala ########## @@ -0,0 +1,345 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.daffodil.layers + +import org.apache.daffodil.processors.TermRuntimeData +import org.apache.daffodil.util.Maybe +import org.apache.daffodil.processors.LayerCharsetEv +import org.apache.daffodil.schema.annotation.props.gen.LayerLengthKind +import org.apache.daffodil.processors.LayerLengthInBytesEv +import org.apache.daffodil.schema.annotation.props.gen.LayerLengthUnits +import org.apache.daffodil.processors.LayerBoundaryMarkEv +import org.apache.daffodil.processors.LayerTransformArgsEv +import java.io.InputStream +import java.io.OutputStream +import org.apache.daffodil.processors.unparsers.UState +import org.apache.daffodil.processors.parsers.PState +import org.apache.daffodil.exceptions.Assert +import org.apache.daffodil.processors.ParseOrUnparseState +import org.apache.daffodil.processors.parsers.Parser + +import org.apache.daffodil.processors.ExplicitLengthEv +import org.apache.daffodil.io.ExplicitLengthLimitingStream +import java.io.ByteArrayOutputStream +import java.io.ByteArrayInputStream +import org.apache.daffodil.util.MaybeULong +import org.apache.daffodil.processors.Failure Review comment: Can you sort these imports? We're not very consistent about this, but we should try to be better about this. I think most IDE's have the capablility, but I at least try to have the java struff first followed by the daffodil imports, and everything sorted alphabetically. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
