stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278235925
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/QuasiElementDecl.scala ########## @@ -40,9 +40,25 @@ sealed class LocalElementDecl( * DetachedElementDecl is used as a place where properties related to the Review comment: I'm wondering if there's a better name for this file? I wouldn't expected to find LocalELementDecl in a file named QuasiElementDecl, though it is a base for all the Quasi elements. Not sure if there's a better name though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
