stevedlawrence commented on a change in pull request #210: Add midBitsToEnd
layer transform
URL: https://github.com/apache/incubator-daffodil/pull/210#discussion_r279361571
##########
File path:
daffodil-test/src/test/scala/org/apache/daffodil/layers/TestLayers.scala
##########
@@ -44,4 +45,9 @@ class TestLayers {
@Test def test_layersErr1() { runner.runOneTest("layersErr1") }
@Test def test_layers4() { runner.runOneTest("layers4") }
+ @Test def test_midBitsToEndMSBF1() {
midBitsToEndRunner.runOneTest("midBitsToEndMSBF1") }
+ @Test def test_midBitsToEndLSBF1() {
midBitsToEndRunner.runOneTest("midBitsToEndLSBF1") }
+
+ @Test def test_midBitsToEnd_unsufficentBits_1() {
midBitsToEndRunner.runOneTest("midBitsToEnd_unsufficentBits_1") }
+
Review comment:
Would it be possible to add more tests? There's a lot of complex bit
logic/shifting going on up above. Would be nice to see some variation in tests
to try to make sure edge cases are covered, e.g. firstBitIndex and/or numBits
more than 8 bits, invalid argument values, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
