mbeckerle commented on a change in pull request #214: Sequences and Separators 
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r284806574
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/InfosetImpl.scala
 ##########
 @@ -1409,6 +1431,18 @@ sealed class DIComplex(override val erd: 
ElementRuntimeData, val tunable: Daffod
     e.setParent(this)
   }
 
+  def maybeMostRecentlyAddedChild(): Maybe[DIElement] = {
 
 Review comment:
   This is kind of a hack. Suggestions welcome for what to do instead. At the 
point we need the child element just added, we've already popped that node from 
the currentElement stack and the focus is back on the parent. I did not want to 
change the invariant about which element is current. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to