It is 11 commits, so needs a squash first. ________________________________ From: Sloane, Brandon <bslo...@tresys.com> Sent: Thursday, May 16, 2019 2:09:06 PM To: dev@daffodil.apache.org Subject: Re: What is status on PR for typeCalc and enums?
I believe it is done. Steve's last comment is a +1, so I think we are good there. I believe I addressed all of Josh's comments as well, but his review seems to have disappeared (likely due to a force-push on my end) ________________________________ From: Beckerle, Mike <mbecke...@tresys.com> Sent: Thursday, May 16, 2019 2:01:29 PM To: dev@daffodil.apache.org Subject: What is status on PR for typeCalc and enums? This PR has been sitting for a while with comments saying "not done reviewing". I approved it, though one such comment is mine. It has one approval, one not done by SL. Brandon, can you comment on whether you are ok with this being merged or have pending changes? This is an important change set, and this feature is needed even in current DFDL-experimental-status form, by many. Please comment on status. Thanks
