mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r286246591
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@ -94,8 +94,7 @@ trait ChoiceDefMixin } } -abstract class ChoiceTermBase( - final override val xml: Node, +abstract class ChoiceTermBase(final override val xml: Node, Review comment: Yet more annoying new info. Eclipse default do not match the scalariform documentation for defaults. In particular, eclipse defaults to aligining the arrows of case statements. But this is false by default in scalariform. One must choose eclipse defaults, then explicitly unset this box. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
