stevedlawrence commented on a change in pull request #223: Daffodil 1444 schema
comp simple types
URL: https://github.com/apache/incubator-daffodil/pull/223#discussion_r289977144
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -577,17 +577,23 @@ trait ElementBaseGrammarMixin
lazy val allowedValue = allowedValueArg
if (this.isOutputValueCalc)
SimpleTypeRetry(this, allowedValue)
- else if (this.isInstanceOf[PrefixLengthQuasiElementDecl] &&
-
this.asInstanceOf[PrefixLengthQuasiElementDecl].detachedReference.impliedRepresentation
== Representation.Text)
- // If an element has text representation and has a prefixed length, it
+ else if (this.isInstanceOf[PrefixLengthQuasiElementDecl]) {
+ //
+ // This predicate used to check the detachedReference for representation
text.
+ // Seems like a mistake. It's just about variable length here.
+ // You can have prefixed length on hexBinary.
+ //
+ // &&
this.asInstanceOf[PrefixLengthQuasiElementDecl].detachedReference.impliedRepresentation
== Representation.Text)
+ //
Review comment:
Agreed, I think this is wrong, I'm not sure keeping this comment around adds
anything. I think it's just confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
