stevedlawrence commented on a change in pull request #230: Enable schema
validation of attribute- and short-form properties
URL: https://github.com/apache/incubator-daffodil/pull/230#discussion_r291972583
##########
File path:
daffodil-lib/src/main/resources/org/apache/daffodil/xsd/XMLSchema_for_DFDL.xsd
##########
@@ -1757,11 +1738,19 @@ this to validate when we load a DFDL Schema.
</xsd:annotation>
</xsd:element>
- <xsd:element name="enumeration" id="enumeration" type="sub:noFixedFacet">
+ <xsd:element name="enumeration" id="enumeration">
<xsd:annotation>
<xsd:documentation
source="http://www.w3.org/TR/xmlschema-2/#element-enumeration"; />
</xsd:annotation>
+ <xsd:complexType>
+ <xsd:complexContent>
+ <xsd:extension base="sub:facet">
+ <xsd:attributeGroup ref="dfdl:RepValuesAGQualified" />
+ <xsd:attributeGroup ref="sub:anyOther" />
Review comment:
I'm not really sure. It's only used in XMLSchema_for_DFDL.xsd, and the sub
prefix has the same namespace as the xsd and xs prefixes, so I don't think it
really provides any benefit. That said, it shows up 261 times in that file, so
it'd be a pretty big diff and would hide the changes in this file. I'm fine
with removing it, but we should do that as a separate bug if we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
