mbeckerle commented on a change in pull request #228: Incremental progress on
Daffodil 1444 schema compiler space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292068715
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/InitiatedTerminatedMixin.scala
##########
@@ -46,8 +46,6 @@ trait InitiatedTerminatedMixin
*/
lazy val hasInitiator = {
val hasOne = initiatorExpr.isKnownNonEmpty
- if (parentSaysInitiatedContent)
- schemaDefinitionUnless(hasOne, "Enclosing group has
initiatedContent='yes', but initiator is not defined.")
hasOne
Review comment:
I'm pretty sure to fix this it has to happen in sequence child (or choice
child or a base they both share). In generating the grammar or parser/unparser
for that sequence child, that's where all the context-specific logic belongs.
At that point the context is clear, and can be passed directly to anything that
needs to make a decision based on it. The element ref or local element decl or
child-term itself is then free of context-specific computations, and just
provides information to the surrounding context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
