mbeckerle commented on a change in pull request #233: Warn when DFDL properties
are ignored
URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293901806
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section12/aligned_data/Aligned_Data.tdml
##########
@@ -267,9 +267,9 @@
<xs:element name="e16">
<xs:complexType>
<xs:sequence>
- <xs:element name="e14" type="xs:string" dfdl:terminator=":"
dfdl:representation="text" dfdl:lengthKind="explicit" dfdl:length="5"
dfdl:encoding="ascii"
Review comment:
Ok, so looking in general at these test changes, you are not distinguishing
redundant properties from irrelevant properties. E.g., having
dfdl:representation="text" on a string is redundant. Having
"binaryBooleanTrueRep" on a string is irrelevant, and indicative of almost
certainly an error. (In fact a switch to escalate such from warning to error
might be of value.)
One could also warn about properties that are unnecessary because they match
what is found in the default format surrounding the schema component, and so
the properties do not need to be expressed on the schema component. From what I
see in this code you are not going that far. I'm fine with that.
So the question here I guess is "Am I understanding this correctly?"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
