bsloane1650 commented on a change in pull request #249: Emit SDE when a type calculator attempts to use an undefined type. URL: https://github.com/apache/incubator-daffodil/pull/249#discussion_r297786079
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dsom/CompiledExpression1.scala ########## @@ -200,14 +205,23 @@ class DPathCompileInfo( val namespaces: scala.xml.NamespaceBinding, val path: String, override val schemaFileLocation: SchemaFileLocation, - val tunable: DaffodilTunables) + val tunable: DaffodilTunables, + @TransientParam val typeCalcMapArg: TypeCalcMap) Review comment: No. All passed-by-name args need to be transient; and that is normally the only reason we need to use TransientParam. In this case, we are using TransientParam because (for an unknown reason) it is simply to possible to unserialize the value, so we avoid doing so. Like with the by-name parameters, we pull a similar trick of having a corresponding field which is serializable. This is the same reason why the corresponding typeCalcMap field is not marked as lazy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
