mbeckerle commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r301239973
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -132,12 +135,35 @@ trait SchemaComponent
}
}
ee
+ }
+
+ /**
+ * Elements that enclose this.
+ *
+ * If this is already an element, this still walks outward to find the
+ * next tier out.
+ */
+ final lazy val enclosingElements: Seq[ElementBase] = LV('enclosingElements) {
Review comment:
Try moving enclosingElements, enclosingTerms, and enclosingComponents to the
factory objects. Can still call them here and delegate to the factory, but
there is no reason for them to reside on the instance objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
