mbeckerle commented on a change in pull request #259: Incremental progress on
schema compilation space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/259#discussion_r303192151
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dpath/Conversions.scala
##########
@@ -43,22 +44,23 @@ object Conversion {
* to convert the type. ST is the start type, the type the recipe has as its
* output type. TT is the target type desired.
*/
- def conversionOps(st: NodeInfo.Kind, tt: NodeInfo.Kind, context: ThrowsSDE):
List[RecipeOp] = {
+ def conversionOps(st: NodeInfo.Kind, tt: NodeInfo.Kind, context:
Expression): List[RecipeOp] = {
import NodeInfo._
val ops: List[RecipeOp] = (st, tt) match {
case (_, Array) => Nil
case (x, y) if (x == y) => Nil
- case (x, Nillable) => {
- // we don't have enough information here to check whether the
- // item under scrutiny is nillable or not.
- Nil
- }
+ // case (x, Nillable) => {
Review comment:
remove commented code throughout file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
