mbeckerle commented on a change in pull request #273: WIP: Add User Defined 
Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331150272
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NodeInfo.scala
 ##########
 @@ -210,6 +210,25 @@ object NodeInfo extends Enum {
     }
   }
 
+  def fromClassTypeName(a: String) = {
+    a match {
+      // TODO figure out better solution
 
 Review comment:
   Probably not a TODO. This solution is ok. The alternative we chatted about 
the other day with Steve also, .... can't recall what it was, but a comment 
that mentions that technique, but suggests we're doing it this way for 
simplicity sake is fine. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to