stevedlawrence commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331505230
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/UDFunctions.scala ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.dpath + +case class UDFunctionCall(recipes: List[CompiledDPath], functionClassObject: Object) + extends FNArgsList(recipes) { + + lazy val maybeEvaluate = functionClassObject.getClass.getMethods.collect { case p if p.getName == "evaluate" => p } Review comment: We might want to tweak how this all works in that case. We probably want to make this non-lazy or explicitly call it so that it's calculated at schema compile time so we don't take that reflection hit on lookup. But then make it transient and add some deserialization logic so that we relookup the eval method on deserializtion. This way, we only take the hit on schema compliation time and on reload, but never at runtime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
