bsloane1650 commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331706184
########## File path: daffodil-test/src/test/java/org/goodudfs/example/StringFunctions/Compare.java ########## @@ -0,0 +1,19 @@ +package org.goodudfs.example.StringFunctions; + +import java.io.Serializable; + +import org.apache.daffodil.udf.FunctionClassInfo; + +@FunctionClassInfo( + name = "compare", + namespace = "http://goodudfs.StringFunctions"; +) +public class Compare implements Serializable { Review comment: Is it possible to insist that all UDFs implement a common UDF interface? Something along the lines of: interface UDF{ public Object evaluate(Object ... args); } I'm not sure how variance works in Java, so it might not be possible to write this signature in such a way that actually allows reasonable signatures in the subclasses. Even just interface UDF{} might be useful as a way for users to mark the fact that these classes are implementing UDFs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
