I just noticed that certain GitHub pull request comments are not being emailed to the commits@daffodil.a.o email list. This seems to only affect comments made in the "Files Changed" tab > "Review changes" comment box. In-line PR comments and top-level "Conversation" comments are still emailed and not affected.
This is a problem since we often use the Review Changes comment box for the +1 comment. This means many +1's are not making it to the dev list which violates the Apache mantra of "if it didn't happen on list, it didn't happen". I've opened a ticket with INFRA to address this issue, as I believe this is an issue with GitBox since that it was sends out emails: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-21041 For now though, this means we should probably avoid adding any review comments to the "Review Changes" comment box. Instead, when giving a +1 or any general pull request comments that aren't in-line, we should make them from the "Conversation" tab of the PR. I'll track the INFRA issue and update this list if this gets resolved and we can go back to using the "Review Changes" comments. - Steve
