I had dead code about 95% complete and some work on another round of unused (maybe locals) back in June, but the branch will be stale now.
Scalafix helps greatly with these tasks but it is still a bit of work. Will take a look and see where that was once this validators stuff is wrapped up. On Mon, Oct 26, 2020 at 2:59 PM Steve Lawrence <slawre...@apache.org> wrote: > We removed a bunch of warnings a while ago when adding Scala 2.12 support: > > https://issues.apache.org/jira/browse/DAFFODIL-2145 > > I suspect it's just a decent amount of work to reenable these warnings > and fix whatever is broke. Something that definitely needs to be done, > it's just been relatively low priority. > > Agreed that we definitely don't want to wait until things make it into > master and the sonar scan is run to find these problems. Getting these > fixed so they never make it to master is ideal. > > - Steve > > > On 10/26/20 2:49 PM, Beckerle, Mike wrote: > > So I got this from sonarcloud. It identifies an unused variable for > sure. Doesn't help me understand who or why it got into testing. > > > > Question: shouldn't our scala compiler settings be giving us a warning > about this, and aren't warnings fatal per our current practices? > > > > I wouldn't expect we'd need solarcloud to find this for us. I'd expect > every developer to see these on every compile. > > > > ________________________________ > > From: SonarCloud <nore...@sonarcloud.io> > > Sent: Monday, October 26, 2020 2:45 PM > > To: Beckerle, Mike <mbecke...@owlcyberdefense.com> > > Subject: [SonarCloud] incubator-daffodil: 1 new issue (new debt: 5min) > > > > Project: incubator-daffodil > > Version: not provided > > > > 1 new issue (new debt: 5min) > > > > Type > > Bug: 0 Vulnerability: 0 Code Smell: 1 > > > > Rules > > Unused local variables should be removed (scala): 1 > > > > Most impacted files > > ConvertTextNumberUnparser.scala: 1 > > > > More details at: > https://sonarcloud.io/project/issues?id=apache_incubator-daffodil&createdAt=2020-10-26T18%3A44%3A35%2B0000 > > > >
