I had the same issue and got tired of this redundancy a while ago so I
disabled notifications from GitHub and only rely on those notifications
from Apache's GitBox.

I think there are two things that I no longer see, which is a bit
annoying, but in practice hasn't been too much of an issue, so I just
deal with it. Those two things are:

1) Pull request comments made in the "Review Changes" thing aren't sent
out by gitbox. This sometimes means I'll miss a +1 (since this is where
we often add hose), especially if +1 was the only comment. Inline
comments do get sent out by gitbox though. I opened a ticket for this
issue with infra but I don't think they've made any progress on fixing this:

https://issues.apache.org/jira/browse/INFRA-21041

2) I *think* Gitbox doesn't send out notifications when a pull request
is updated with new commits--fixup commits are a pretty important and
frequent part of our workflow. Fortunately, people usually add a comment
when new commits are added, which GitBox does send out, so I don't
usually don't miss these.


My solution for these two issues so far has just been to periodically
manually check reviews I've made for review comments or check PR's
others have made for updated commits. It's a bit of a manual process,
but not awful, and I prefer it over all the double emails.

The other option would be to not subscribe to commits@daffodil.a.o, but
I think you'd then you miss out on Jira updates, and all the other stuff
that goes to commits@. It's definitely alot more than gitbox
notifications, so probably not recommended. And I think the incubator
prefers that all committers/PPMC members subscribe to commits, since it
really is the only place that gives the (almost) complete picture of
changes.

We could have suggestions that people not add "Review Changes" comments,
and when updates are made to pull requests we always add a comment
saying there's an update. But that's hard to remember and enforce. We
really just need Infra to fix these issues with gitbox, but I'm not sure
this is high priority. Though, from a traceability perspective, one
could argue that there are comments and PR information that gitbox is
missing and so isn't "happening on a mailing list" so maybe the priority
should be pretty high for infra, since "happening on a mailing list" is
a pretty important mantra to ASF.

- Steve



On 2/3/21 10:12 AM, Beckerle, Mike wrote:
> I seem to get two of everything.
> 
> I get one message from "GitBox" sent to commits@daffodil
> I get one from "notificati...@github.com" to 
> incubator-daffo...@noreply.github.com
> 
> I cannot guarantee that every message always shows up to both of these.
> 
> If I unsubscribe from the latter, will I miss some things, or is all the same 
> traffic always sent to both.
> 
> Mike Beckerle | Principal Engineer
> 
> mbecke...@owlcyberdefense.com <mailto:bhum...@owlcyberdefense.com>
> 
> P +1-781-330-0412
> 
> Connect with us!
> 
> <https://www.linkedin.com/company/owlcyberdefense/><https://twitter.com/owlcyberdefense>
> 
> <https://owlcyberdefense.com/resources/events/>
> 
> **
> 
> The information contained in this transmission is for the personal and 
> confidential use of the individual or entity to which it is addressed. If the 
> reader is not the intended recipient, you are hereby notified that any 
> review, 
> dissemination, or copying of this communication is strictly prohibited. If 
> you 
> have received this transmission in error, please notify the sender immediately
> 

Reply via email to