Updating vote to +1 The issues I identified appear to be present in the 3.1.0 as well, so no reason for them to hold up this release. ________________________________ From: Interrante, John A (GE Research, US) <john.interra...@ge.com> Sent: Monday, December 6, 2021 11:25 AM To: dev@daffodil.apache.org <dev@daffodil.apache.org> Subject: RE: [VOTE] Release Apache Daffodil 3.2.0-rc1
+1 (binding) Didn't have much time and others already did a lot of checking, but I checked: [OK] visited each link in email [OK] read Summary of Changes, looks good [OK] downloaded daffodil zip, runtime2 javadoc/sources/jar/pom [OK] no unexpected binaries in source [MINOR] inspected runtime2 javadoc/sources/jar/pom - runtime2 javadocs are not as complete as they could be [MINOR] inspected daffodil zip - libs have log4j-api-2.13.2 and log4j-core-2.14.1 (versions don't match) I checked why log4j-api and log4j-core aren't the same version. We specify version for jars in project/Dependencies.scala. Adding log4j-api-scala 12.0 also adds log4j-api 2.13.2 transitively but log4j-core 2.13.2 is a runtime dependency, meaning it isn't added transitively. project/Dependencies.scala 33: "org.apache.logging.log4j" %% "log4j-api-scala" % "12.0", 34: "org.apache.logging.log4j" % "log4j-core" % "2.14.1" % "it,test", 48: "org.apache.logging.log4j" % "log4j-core" % "2.14.1", We added these three lines to project/Dependencies.scala in PR #605 but we didn't add log4j-api for some reason even though log4j-scala's README suggests adding both log4j-api and log4j-core at the same time. We should add the same version of log4j-api for consistency, which will allow Scala Steward to bump both of them to even later versions (note log4j-api-scala 12.0 bases its API on log4j-api 2.13.2, but there should be no backward API incompatibilities in future log4j 2.x releases). I've created DAFFODIL-2602 for this issue, but its fix can wait until after we release 3.2.0. -----Original Message----- From: Mike Beckerle <mbecke...@apache.org> Sent: Wednesday, December 1, 2021 2:04 PM To: dev@daffodil.apache.org Subject: EXT: [VOTE] Release Apache Daffodil 3.2.0-rc1 WARNING: This email originated from outside of GE. Please validate the sender's email address before clicking on links or attachments as they may not be safe. Hi all, I'd like to call a vote to release Apache Daffodil 3.2.0-rc1. All distribution packages, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/daffodil/3.2.0-rc1/ Staging artifacts can be found at: https://repository.apache.org/content/repositories/orgapachedaffodil-1025/ This release has been signed with PGP key 13A680AF, corresponding to mbecke...@apache.org, which is included in the KEYS file here: https://downloads.apache.org/daffodil/KEYS The release candidate has been tagged in git with v3.2.0-rc1. For reference, here is a list of all closed JIRAs tagged with 3.2.0: https://s.apache.org/daffodil-issues-3.2.0 For a summary of the changes in this release, see: https://daffodil.apache.org/releases/3.2.0/ Please review and vote. The vote will be open for at least 72 hours (Monday December 6, 14:00 EST.US). [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Thanks, - Mike Beckerle
