Steve, Mike, Shane,
Should we hold off resolving DAFFODIL-2743 a little bit longer? I grep’ed
“deprecated” in my daffodil source tree after pulling commit
11a11afc3f99fca8446cc5206f74446d6e825a33 and I found comments indicating we
might want to change one or more places in Compiler.scala. Let’s discuss.
John
File: daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala
65 │ final class ProcessorFactory private(
66 │ private var optRootSpec: Option[RootSpec],
67 │ /*
68 │ * compilerExternalVarSettings supports the deprecated API
69 │ * where external variable settings can be supplied to the compiler
70 │ * instance.
76 │ var compilerExternalVarSettings: Queue[Binding],
145 │ class Compiler private (var validateDFDLSchemas: Boolean,
146 │ var tunables : DaffodilTunables,
147 │ /*
148 │ * Supports deprecated feature of establishing external vars on the
compiler object.
149 │ * These are just saved and passed to the processor factory which
incorporates them into
150 │ * the variable map of the data processor.
151 │ *
152 │ * This argument can be removed once this deprecated feature is
removed.
153 │ */
154 │ private var externalDFDLVariables: Queue[Binding],
210 │ // Not deprecated so that we can implement the deprecated things
211 │ // and reuse code.
212 │ // When the deprecated methods go away, so should this.
213 │ //
214 │ def withExternalDFDLVariablesImpl(variables: Seq[Binding]): Compiler
= {
From: Thompson, Dave <[email protected]>
Sent: Friday, November 18, 2022 6:48 AM
To: [email protected]; [email protected]
Subject: EXT: RE: [jira] [Commented] (DAFFODIL-2743) remove all deprecated
methods/classes/objects
WARNING: This email originated from outside of GE. Please validate the sender's
email address before clicking on links or attachments as they may not be safe.
Shane,
Good morning.
I see you made a commit (11a11afc3f99fca8446cc5206f74446d6e825a33) to daffodil
referencing JIRA ticket DAFFODIL-2743.
Can you update the ticket with a comment referencing the commit hash and if it
is complete change the Status to resolved.
That way it will show up in my Resolved list and I know I can verify/close it.
Thanks,
Dave Thompson
[cid:[email protected]]
-----Original Message-----
From: Shane Dell (Jira) <[email protected]<mailto:[email protected]>>
Sent: Thursday, November 10, 2022 10:37 AM
To: [email protected]<mailto:[email protected]>
Subject: [jira] [Commented] (DAFFODIL-2743) remove all deprecated
methods/classes/objects
[
https://issues.apache.org/jira/browse/DAFFODIL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631713#comment-17631713
]
Shane Dell commented on DAFFODIL-2743:
--------------------------------------
[~mbeckerle] [~slawrence] Could you assign this issue to me? I would like to
start contributing to the Daffodil project more.
> remove all deprecated methods/classes/objects
> ---------------------------------------------
>
> Key: DAFFODIL-2743
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2743
> Project: Daffodil
> Issue Type: Improvement
> Components: Clean Ups
> Affects Versions: 3.4.0
> Reporter: Mike Beckerle
> Priority: Major
>
> There are now 170 occurrences of "@deprecated" in the daffodil libraries.
> Next major release these should all be removed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
