Yeah, sorry, I hit send faster than my brain. You're right. On Wed, Mar 8, 2023 at 9:55 AM Mike Beckerle <[email protected]> wrote:
> I think the only thing that works is create PRs when you are requesting > review, not before. > > > On Wed, Mar 8, 2023 at 12:51 PM Adam Rosien <[email protected]> wrote: > > > Got it. Make drafts on your own forks then? > > > > On Tue, Mar 7, 2023 at 9:04 AM Mike Beckerle <[email protected]> > wrote: > > > > > Draft PRs - intentionally created for review, are important. We don't > > want > > > those ignored. > > > > > > > > > On Tue, Mar 7, 2023 at 11:34 AM Adam Rosien <[email protected]> wrote: > > > > > > > Would it be possible to modify the email trigger script to ignore > draft > > > PR > > > > updates? > > > > > > > > On Tue, Mar 7, 2023 at 8:19 AM Mike Beckerle <[email protected]> > > > wrote: > > > > > > > > > I'd like to request that people change the way they work slightly. > > > > > > > > > > Please do NOT create a pull request until you are actually > requesting > > > > > people to review your work. There's some things in github that > seem > > to > > > > > suggest creating a PR then doing one's work there. This is > > problematic > > > > due > > > > > to the high traffic volume of email it creates to this list. > > > > > > > > > > Once you create a PR, this mailing list sees every push to your > > > > > development branch on your fork, regardless of whether those are > > > sensible > > > > > points for additional review or you are just effectively making a > > > > > checkpoint on your progress. > > > > > > > > > > Every one of these messages require processing time from everyone > to > > > > decide > > > > > whether review is needed, or if you are just checkpointing your > work > > > and > > > > we > > > > > should tune-in later for the real review cycle. > > > > > > > > > > To me the important trigger email is creation of a new PR. At that > > > point > > > > > you are requesting people's time to review, and importantly... to > > > review > > > > > updates you make subsequently. If you open a PR too early the > emails > > > > don't > > > > > serve this purpose. They're just frankly, spam that I have to > delete. > > > > > > > > > > I don't want to discourage people from creating early DRAFT PRs for > > > early > > > > > feedback on things. That's fine and very much encouraged. But early > > PRs > > > > > should be closed and when ready for review again, a new PR created. > > > > > > > > > > Thanks for your help in this matter > > > > > > > > > > > > > > >
