+1 for v3.5.0 rc1 - Verified all v3.5.0 assigned JIRA tickets are resolved/closed. - Successfully executed Daffodil sub-module SBT Test suites on CentOS 7 and the following Java versions: - Java 8 - Java 11 - Java 17 - Executed the nightly performance on Java versions with no unexpected failures/errors: - Java 8 - Java 11 - Java 17
-----Original Message----- From: Steve Lawrence <[email protected]> Sent: Monday, June 26, 2023 10:50 AM To: [email protected] Subject: Re: [VOTE] Release Apache Daffodil 3.5.0-rc1 +1 (binding) I checked: [OK] hashes and signatures of source and helper binaries are correct [OK] signature of git tag is correct [OK] source release matches git tag (minus KEYS file) [OK] source compiles and all tests pass (both en_US and de_DE) (minor exception with DAFFODIL-2612 and -2599) [OK] helper tgz/zip/msi/rpm all contain the same content except where expected [OK] jars in helper binaries and the repository are exactly the same [OK] jars built from source are exactly the same as helper binary jars [OK] distributed dependencies in helper binaries are same as from maven [OK] src, binaries, and jars include correct LICENSE/NOTICE [OK] RAT check passes [OK] no unexpected binaries in source [OK] rpm and msi install and run with basic usage [OK] ~80 public and private DFDL schema projects pass tests [OK] No issues found in JavaDoc and ScalaDoc [OK] No open CVE's found using sbt-dependency-check plugin [OK] Daffodil NiFi processor builds and tests pass On 2023-06-22 04:49 PM, Mike Beckerle wrote: > I'm withdrawing my suggestion that we entertain an RC2. > > I'm voting +1 on 3.5.0-RC1 > > > On Thu, Jun 22, 2023 at 2:45 PM Steve Lawrence <[email protected]> wrote: > >> I've added a comment to the PR about a slightly different approach to >> the problem. But if that approach is taken, I think that might be a >> more invasive change that should probably wait until next release. >> But maybe that isn't the best approach, or could be done in the next release? >> >> Another consideration is I'll be gone for a couple weeks starting >> July 3, so I only have next week to do release manager activities. >> That >> *should* be enough if we start a new vote, but it doesn't leave a lot >> of time, considering there's a 72 hour voting period followed by >> approx 24 hours for release artifacts to reach mirrors. >> >> On 2023-06-22 01:43 PM, Mike Beckerle wrote: >>> I know I already voted +1. >>> >>> I'd like us to consider merging this PR - i.e., create an RC2 so >>> that we can include this late change. >>> >>> https://github.com/apache/daffodil/pull/1037 >>> >>> This improvement/feature is rather important to various >>> cybersecurity applications that try to use DFDL schemas both for >>> Daffodil >> parse/unparse, >>> but also as XML schemas with a variety of separate validators >>> including those written in C/C++ so which cannot use Daffodil's >>> schemaLocation resolver. >>> >>> >>> On Wed, Jun 21, 2023 at 5:16 PM Mike Beckerle <[email protected]> >> wrote: >>> >>>> +1 >>>> >>>> I verified all checksums/hashes via the script which is a comment >>>> on the release workflow page. >>>> >>>> I re-tested all the schemas Owl has (public and private source) >>>> using >> the >>>> 3.5.0-rc1 with Java 17. >>>> This is 84 total. Only those expected to fail (still in >>>> development) failed. All others succeeded. >>>> >>>> The subset of the portable schemas still work with IBM DFDL >>>> crosstester (which did need updates for 3.5.0) >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> On Wed, Jun 21, 2023 at 10:19 AM Steve Lawrence >>>> <[email protected]> >>>> wrote: >>>> >>>>> Hi all, >>>>> >>>>> I'd like to call a vote to release Apache Daffodil 3.5.0-rc1. >>>>> >>>>> All distribution packages, including signatures, digests, etc. can >>>>> be found at: >>>>> >>>>> https://dist.apache.org/repos/dist/dev/daffodil/3.5.0-rc1/ >>>>> >>>>> Staging artifacts can be found at: >>>>> >>>>> >> https://repository.apache.org/content/repositories/orgapachedaffodil- >> 1033/ >>>>> >>>>> This release has been signed with PGP key 36F3494B033AE661, >>>>> corresponding to [email protected], which is included in the >>>>> KEYS file here: >>>>> >>>>> https://downloads.apache.org/daffodil/KEYS >>>>> >>>>> The release candidate has been tagged in git with v3.5.0-rc1. >>>>> >>>>> For reference, here is a list of all resolved JIRA issues tagged >>>>> with >>>>> 3.5.0: >>>>> >>>>> https://s.apache.org/daffodil-issues-3.5.0 >>>>> >>>>> For a summary of the changes in this release, see: >>>>> >>>>> https://daffodil.apache.org/releases/3.5.0/ >>>>> >>>>> Please review and vote. The vote will be open for at least 72 >>>>> hours (Monday, 26 June 2023, 11:00am EDT). >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove (and reason why) >>>>> >>>>> Thanks, >>>>> - Steve >>>>> >>>> >>> >> >> >
