My vote -1 Too many regressions. Existing schemas need to keep working if at all possible.
I think the issue of properties having whitespace e.g., dfdlx:repValues="0 " breaking due to the trailing space is a blocker. If that was tolerated before, it needs to be tolerated forever. I think the DAFFODIL-2857 is also a blocker. Each of those breaks what is otherwise a stable large complex schema, some of which are already being deployed. Honestly I'm being selfish. If we were to roll forward with 3.6.0-rc1, I'd have to tell our engineering department to skip version 3.6.0 of Daffodil. Because that's easier than having to modify the schemas. On Thu, Oct 26, 2023 at 12:25 PM Steve Lawrence <slawre...@apache.org> wrote: > I've found two issues related to dfdlx:repType while regression testing > this release: > > * DAFFODIL-2855: Scoping different when using dfldx:repType vs type > > * DAFFODIL-2857: Different prefixes for same namespace fails to compile > with dfdlx:repType > > Although 2855 causes regressions, it does have the correct behavior for > repType, so it might be worth not fixing, with the right change being to > correct how non-repType properties are scoped, which is potentially a > major breaking change more suitable for 4.0.0. > > But 2857 is a new bug that does break some existing schemas, and could > potentially be a stumbling block for other schemas without an obvious > solution. The workaround is straightforward--use consistent prefixes for > namepaces--but it's not very clear based on the error message. > > Any thoughts if this warrants an rc2? Feels like it to me, but I'd like > to hear other opinions before cancelling the vote. > > > On 2023-10-23 12:14 PM, Steve Lawrence wrote: > > Hi all, > > > > I'd like to call a vote to release Apache Daffodil 3.6.0-rc1. > > > > All distribution packages, including signatures, digests, etc. can be > > found at: > > > > https://dist.apache.org/repos/dist/dev/daffodil/3.6.0-rc1/ > > > > Staging artifacts can be found at: > > > > > https://repository.apache.org/content/repositories/orgapachedaffodil-1034/ > > > > This release has been signed with PGP key 36F3494B033AE661, > > corresponding to slawre...@apache.org, which is included in the KEYS > > file here: > > > > https://downloads.apache.org/daffodil/KEYS > > > > The release candidate has been tagged in git with v3.6.0-rc1. > > > > For reference, here is a list of all resolved JIRA issues tagged with > > 3.6.0: > > > > https://s.apache.org/daffodil-issues-3.6.0 > > > > For a summary of the changes in this release, see: > > > > https://daffodil.apache.org/releases/3.6.0/ > > > > Please review and vote. The vote will be open for at least 72 hours > > (Thursday, 26 October 2023, 12:30 EST). > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > >
