-1
While testing in Windows, the Data Editor failed to start because it wasn't
able to start up an Ωedit server. Turns out this is due to a breaking
change in Node >=18 to address a recent serious CVE in the
child_process.spawn function. Under Windows when calling a script (like
.bat or .cmd, etc.) it is now required that the {shell: true} spawn option
be used. The update to comply with this breaking API change was made in
Ωedit 0.9.83, but RC2 uses Ωedit 0.9.82. The PR to upgrade Ωedit (
https://github.com/apache/daffodil-vscode/commit/ba7cfe0210f88a5e17fca793d3f325b28c852296)
was tested, reviewed, approved, and it was just merged this afternoon.
The Data Editor now once again works under Windows as well as Linux and
macOS. In light of this, I think a new RC is prudent.
-Davin
On Tue, Oct 8, 2024 at 8:04 AM Shane Dell <shaned...@apache.org> wrote:
> Hello all,
>
> I'd like to call a vote to release Apache Daffodil™ Extension for Visual
> Studio Code 1.4.0-rc2.
>
> All distribution packages, including signatures, digests, etc. can be
> found at:
> https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.4.0-rc2
>
> This release has been signed with PGP key
> 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding
> to shaned...@apache.org, which is included in the KEYS file here:
> https://downloads.apache.org/daffodil/KEYS
>
> The release candidate has been tagged in git with 1.4.0-rc2.
>
> For reference, here is a list of all closed GitHub issues tagged with
> 1.4.0:
> https://github.com/apache/daffodil-vscode/milestone/5?closed=1
>
> Please review and vote. The vote will be open for at least 72 hours
> (Friday, 11 October 2024, 8:00am EST).
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Documentation for 1.4.0 can be found here
>
> https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil%E2%84%A2-Extension-for-Visual-Studio-Code:-v1.4.0
> .
>
> Thank you,
>
> - Shane Dell
>
