I took a look at this and while the code looks good to me I noticed a significant slow down when running the standard test suite. It seems like we lost concurrency somewhere in these changes as it takes roughly 3x longer to run the tests compared to the main branch on my machine. None of your changes in particular jumped out at me, but I did test this a couple times.
Other than that I'd say your changes look good and it's great to get such a significant speed up for schema compilation. I'm just hoping that we can have it without sacrificing test execution time as well. Josh ________________________________ From: Mike Beckerle <mbecke...@apache.org> Sent: Monday, December 23, 2024 9:06 AM To: dev@daffodil.apache.org <dev@daffodil.apache.org> Subject: PR review need https://github.com/apache/daffodil/pull/1396 is the PR for a big improvement in schema compiler speed. Like 2+ minutes to 15 seconds. If this could get reviewed asap this week it would be great and would avoid the need to create temporary local fork versions for use in schema work.
