ASF Infra has resolved this issue.
However, I created a test release locally and with the new action and they were
not perfectly reproducible. It looks like there is still some non-determinism,
though it seems somewhat rare.
It looks like the vsce generates a "[Content_Types].xml" file in the .vsix file
that just lists a bunch of mime type/extension pairs based on files found in the
.vsix file, e.g.
<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types";>
<Default Extension=".json" ContentType="application/json"/>
<Default Extension=".vsixmanifest" ContentType="text/xml"/>
<Default Extension=".md" ContentType="text/markdown"/>
<Default Extension=".txt" ContentType="text/plain"/>
<Default Extension=".ico" ContentType="image/x-icon"/>
<Default Extension=".svg" ContentType="image/svg+xml"/>
...
</Types>
Order doesn't seem matter, but the order these extensions are generated is
non-deterministic, I think based on the order vsce happens to see files or the
order things come out of hash map. Here's the function that writes the file:
https://github.com/microsoft/vscode-vsce/blob/main/src/package.ts#L1588-L1607
Making it deterministic is probably just a matter of sorting the contentTypes so
is a small change. I can create a PR to fix this, but it would delay this
release until the PR is merged and a new vsce version is released. VSCE makes
fairly frequently releases, but we don't have any control over it.
Alternatively, if we don't want to wait for a new vsce release, we could skip
using the new workflow for this release (since automated CI signing requires
reproducible builds).
On 2025-04-21 07:14 AM, Steve Lawrence wrote:
+1 from me
One issue is that there is something broken with the new release candidate
action for daffodil-vscode where it can't see the svn username property. Other
daffodil repos can see it fine.
I have added this PR to debug it, but it needs some +1's to merge (which I'll do
a quick test and then it can be reverted).
https://github.com/apache/daffodil-vscode/pull/1231
That test should give some details that we can provide to ASF infra to resolve
the issue.
The old release workflow should still work if you don't want to wait, but I'm
hoping it will only take infra a day or so to track down the issue once we can
provide these details.
On 2025-04-16 10:59 AM, Shane Dell wrote:
Hello all,
The Apache Daffodil™ Extension for Visual Studio Code development team
believes we are ready to create a release candidate for 1.4.1 of the Apache
Daffodil™ Extension for Visual Studio Code. The list of issues for the
Visual Studio Code Extension can be found here
https://github.com/apache/daffodil-vscode/issues. Closed issues for 1.4.1
can be found at
https://github.com/apache/daffodil-vscode/milestone/11?closed=1. Are there
any problems, complaints or concerns?
This discussion thread will be opened for at least 72 hours before moving
forward. This will be Monday, April 21st at 11 AM.
Thank you,
Shane Dell
