[ 
https://issues.apache.org/jira/browse/DATAFU-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532099#comment-16532099
 ] 

Matthew Hayes commented on DATAFU-132:
--------------------------------------

One potential issue I see with this is that it would be easy to accidentally 
release a version of DataFu targeting Java 8, which then wouldn't work for 
those folks who are using Java 7, which is the minimum version required for 
Hadoop 2.7.  This was the motivation behind the sweeney check.  I'd feel a lot 
more comfortable merging this change in if we had some protection against this. 
 

One possible solution that comes to mind is using the {{release}} flag in 
{{gradle.properties}} to control whether we validate the java version more 
strictly or not.  When we generate the source release we set this flag to true 
so that SNAPSHOT is not appended to the artifacts.  We can use the flag to do 
this validation as well.  Artifacts should be generated from the source release 
only.

This will enable users to use Java 8 or other newer versions when developing 
contributions but will help ensure we release artifacts that are still 
compatible with Java 7.

Thoughts?  I'll attach an updated patch shortly.

> Make DataFu compile with Java 8
> -------------------------------
>
>                 Key: DATAFU-132
>                 URL: https://issues.apache.org/jira/browse/DATAFU-132
>             Project: DataFu
>          Issue Type: Improvement
>    Affects Versions: 1.4.1
>            Reporter: Eyal Allweil
>            Priority: Major
>         Attachments: DATAFU-132.patch
>
>
> Currently DataFu only compiles with Java 7. It would be great if Java 8+ 
> could be used. The attached patch makes this possible by making the Java 
> version check more permissive (anything above Java 7).
> I've done a build and tests, and deployed the resulting jar and tested a 
> macro and UDF with it, compiling with Java 8.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to