eyala commented on a change in pull request #15: Add Spark functionality to DataFu, datafu-spark URL: https://github.com/apache/datafu/pull/15#discussion_r288965080
########## File path: datafu-spark/src/test/resources/META-INF/services/datafu.spark.PythonResource ########## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +datafu.spark.ExampleFiles +datafu.spark.Py4JResource +datafu.spark.PysparkResource Review comment: Do we need to update the license file even for things that are only in our tests, not in our "real" jar? The py4j zips I took as is - but I had to manually create the pyspark zips by cutting them out of the Spark source code (making a zip from the pyspark directory from the relevant Spark branch/tag) I suspect this will make using/reusing these files difficult. But I will look into adding py4j as a tests Gradle dependency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
