eyala commented on PR #21: URL: https://github.com/apache/datafu/pull/21#issuecomment-1099986584
I think you're correct in your analysis - this does make the join basically an inner join. There are two issues that need to be addressed before we can merge this, one theoretical and one practical. 1) I think making it a working left outer join is a good idea, but I don't want to change the existing behavior. What do you think about adding a parameter like the Spark join type? (@uzadude, what do you think?) Then we can make an inner join remain the default. 2) In order to merge it, we would need you to modify/add a test so that your code can be checked automatically. (this is crucial for keeping our project maintainable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@datafu.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
