----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18308/#review35916 -----------------------------------------------------------
+1 Looks good to me! Thanks for doing this :) Can you attach the patch to the JIRA? I'll then go ahead and commit it. - Matthew Hayes On Feb. 20, 2014, 1:30 p.m., wang jian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18308/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 1:30 p.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > ------- > > This diff is to update entropy UDF naming conventions and documentation based > on JIRA: https://issues.apache.org/jira/browse/DATAFU-26 > > > Diffs > ----- > > src/java/datafu/pig/stats/entropy/CondEntropy.java PRE-CREATION > src/java/datafu/pig/stats/entropy/EmpiricalCountEntropy.java PRE-CREATION > src/java/datafu/pig/stats/entropy/Entropy.java a074bc0 > src/java/datafu/pig/stats/entropy/StreamingCondEntropy.java 67ad4d3 > src/java/datafu/pig/stats/entropy/StreamingEntropy.java 707e690 > test/pig/datafu/test/pig/stats/entropy/ChaoShenEntropyTests.java > PRE-CREATION > test/pig/datafu/test/pig/stats/entropy/CondEntropyTests.java PRE-CREATION > test/pig/datafu/test/pig/stats/entropy/EmpiricalCountEntropyTests.java > PRE-CREATION > test/pig/datafu/test/pig/stats/entropy/EntropyTests.java 8ef94c3 > test/pig/datafu/test/pig/stats/entropy/StreamingChaoShenEntropyTests.java > 77a8e8b > > test/pig/datafu/test/pig/stats/entropy/StreamingEmpiricalCondEntropyTests.java > 151bf8b > test/pig/datafu/test/pig/stats/entropy/StreamingEmpiricalEntropyTests.java > a98d79f > > Diff: https://reviews.apache.org/r/18308/diff/ > > > Testing > ------- > > Unit test done > > > Thanks, > > wang jian > >
